Record visited type to prevent stack overflow #788
Conversation
Ao-senXiong
changed the title
Ao-senXiong
changed the title
Ao-senXiong
changed the title
Ao-senXiong
changed the title
| RawtypeInstantiation<?> wildcardInstance = new @A RawtypeInstantiation<C>(); | ||
| } | ||
|
|
||
| <D extends RawtypeInstantiation<D>> void bar(D b) { |
There was a problem hiding this comment.
Should the parameter b used for something? Or can it be removed?
| // https://github.com/eisop/checker-framework/issues/778 | ||
| import viewpointtest.quals.*; | ||
|
|
||
| public class RawtypeInstantiation<C extends RawtypeInstantiation<C>> { |
There was a problem hiding this comment.
Can you think of a better class name? The key isn't rawness, it's the C extends R<C> bound, right?
|
|
||
| public class RawtypeInstantiation<C extends RawtypeInstantiation<C>> { | ||
|
|
||
| void foo() { |
There was a problem hiding this comment.
Can you pick better names than foo and bar?
| RawtypeInstantiation rawtypeInstance = new @A RawtypeInstantiation(); | ||
| // :: warning: (cast.unsafe.constructor.invocation) | ||
| RawtypeInstantiation<D> genericInstance = new @A RawtypeInstantiation<>(); | ||
| // :: warning: (cast.unsafe.constructor.invocation) |
There was a problem hiding this comment.
All these warnings distract from the point of this test. Can you add a suitable constructor and suppress the warning there once?
| // :: warning: (cast.unsafe.constructor.invocation) | ||
| RawtypeInstantiation<D> genericInstance = new @A RawtypeInstantiation<>(); | ||
| // :: warning: (cast.unsafe.constructor.invocation) | ||
| RawtypeInstantiation<?> wildcardInstance = new @A RawtypeInstantiation<D>(); |
There was a problem hiding this comment.
How do these tests ensure the proper viewpoint adaptation happened?
| if (visitedTypes.contains(declared)) { | ||
| return declared; | ||
| } | ||
| try { |
There was a problem hiding this comment.
Are there really exceptions that can happen in this code? Adding these large try blocks makes it hard to see what changed.
Fixes #778