Enable Javadoc checks for src/test directories
#871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ao-senXiong
changed the title
wmdietl
reviewed
Aug 20, 2024
| @@ -633,6 +633,7 @@ task allJavadoc(type: Javadoc, group: 'Documentation') { | |||
| project(':checker-qual').sourceSets.main.allJava, | |||
| project(':checker').sourceSets.main.allJava, | |||
| project(':framework').sourceSets.main.allJava, | |||
| project(':framework').sourceSets.test.allJava, | |||
There was a problem hiding this comment.
This is great and reveals 14 errors in javadoc!
Should the same be done for :checker?
There was a problem hiding this comment.
Sounds good to me! I will udpate the gradle file.
There was a problem hiding this comment.
There is also dataflow/src/test, checker/src/testannotations, and checker-util/src/test.
Please also fix the javadoc errors revealed by the new check.
There was a problem hiding this comment.
Maybe framework-test/src/test as well?
There was a problem hiding this comment.
I will leave do checker/src/testannotations later in a new PR. Looks like we need to define the source set for testannotations folder.
Ao-senXiong
changed the title
wmdietl
changed the title
src/test directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #827 (comment)