Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress cast imcomparable warnings #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suppress cast imcomparable warnings #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion guava/src/com/google/common/primitives/UnsignedInteger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,10 @@ public UnsignedInteger mod(UnsignedInteger val) {

/** Returns the value of this {@code UnsignedInteger} as a {@code long}. */
@Override
@SuppressWarnings("value:cast.unsafe") // Unknown long to PolyValue long is ok
@SuppressWarnings({
"value:cast.unsafe",
"cast.incomparable"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there two warnings now? There should be two separate comments then. Also, is the incomparable warning for multiple type systems?

Also, if toLong returns the top qualifier Unknown, why is this no longer an unsafe downcast?

}) // Unknown long to PolyValue long is ok
public @PolyValue long longValue(@PolyValue UnsignedInteger this) {
return (@PolyValue long) toLong(value);
}
Expand Down
Loading