Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update flake #544

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Sep 15, 2023

No description provided.

@Alizter
Copy link
Collaborator Author

Alizter commented Sep 15, 2023

@ejgallego Looks like serlib isn't building?

@ejgallego
Copy link
Owner

@ejgallego Looks like serlib isn't building?

That seems pretty odd, I guess a problem with some newer ppx version?

I'll have a look when I can.

@Alizter Alizter force-pushed the ps/branch/chore__update_flake branch from f275917 to aa2e002 Compare October 2, 2023 02:23
@Alizter
Copy link
Collaborator Author

Alizter commented Oct 2, 2023

There are hardcoded versions in the flake which were causing the issue. I've pushed a fix, let's see if it works.

@Alizter Alizter force-pushed the ps/branch/chore__update_flake branch from aa2e002 to 6096f4c Compare October 2, 2023 02:54
@Alizter
Copy link
Collaborator Author

Alizter commented Oct 2, 2023

Looks like it worked. There was a TS formatting issue which I also fixed.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the ps/branch/chore__update_flake branch from 6096f4c to 58ac7bb Compare October 2, 2023 03:50
@Alizter
Copy link
Collaborator Author

Alizter commented Oct 2, 2023

FTR you can easily update the format for nix, TS and ocaml by doing nix fmt.

@Alizter Alizter merged commit db60fe0 into ejgallego:main Oct 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants