[goals] Allow command to process several Coq commands.
#823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
command_multiple
branch
3 times, most recently
from
a34c584
to
bd85ad8
Compare
ejgallego
added
kind: enhancement
This is a prototype extension. Note the important change here in behavior here, but IMHO it is needed: if the commands in `command` fail, we will now fail the request. I think in general we may allow some form of error recovery here, but for now we just let clients recover. It does seem that CoqPilot / Pytanque do need even a more powerful interface, but this will allow the them to make some progress for nwo. Thanks to CoqPilot devs for feedback on this.
ejgallego
force-pushed
the
command_multiple
branch
from
bd85ad8
to
81b8914
Compare
ejgallego
changed the title
command to process several Coq commands.command to process several Coq commands.
|
cc: @amblafont , note the two changes in goal pre-processing:
AFAICT they should be backwards compatible with your use case. We will provide a more advanced speculative execution API soon, however I don't think you need it. |
|
@gbdrt this is the PR implementing This way we can access the more fancy document processing stuff, like error recovery, from run finally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype extension.
Note the important change here in behavior here, but IMHO it is
needed: if the commands in
commandfail, we will now fail therequest.
I think in general we may allow some form of error recovery here, but
for now we just let clients recover.
It does seem that CoqPilot / Pytanque do need even a more powerful
interface, but this will allow the them to make some progress for nwo.
Thanks to CoqPilot devs for feedback on this.