Code Actions #840
Merged
Code Actions #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
codeAction
branch
from
31b0367
to
b56c2a8
Compare
ejgallego
added
kind: enhancement
ejgallego
force-pushed
the
codeAction
branch
6 times, most recently
from
516af88
to
643654a
Compare
ejgallego
force-pushed
the
codeAction
branch
6 times, most recently
from
556df05
to
c8a9296
Compare
ejgallego
added a commit
that referenced
this pull request
Oct 3, 2024
This is in preparation for cleaner code in #840
ejgallego
added a commit
that referenced
this pull request
Oct 3, 2024
This is in preparation for cleaner code in #840
Not sure I'm happy about the impact of this, but not sure either how to make it more minimal. Some more abstraction w.r.t. async events would be welcome, the error / diagnostic separation as of now either is not super user-friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide primitive support for the
textDocument/codeActionrequest, for Coq's quickfixes (c.f. coq/coq#19147 )In particular, we now store the quickfix metadata that Coq may send in the diagnostics extra data, which is then queried by the request handler.
This should not provide a lot of overhead but beware.
We introduce a new kind of
Inmediaterequest, this should help withcodeActionand fordocumentSymbolwhen in non continuous mode. c.f. #816This opens again the question about why errors are processed specially w.r.t. other async data like
feedback.This would IMHO require a greater intervention upstream.