Do we need this?

ejweber · Jun 29, 2023 · ac8d6c7 · ac8d6c7
1 parent a8f9bde
commit ac8d6c7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/engineapi/instance_manager.go b/engineapi/instance_manager.go
@@ -375,7 +375,8 @@ func getBinaryAndArgsForReplicaProcessCreation(r *longhorn.Replica,
 
 	if engineCLIAPIVersion >= 9 {
 		args = append(args, "--replica-instance-name", r.Name)
-		args = append([]string{"--volume-name", r.Spec.VolumeName}, args...)
+		// We already pass the command-specific --volume-name flag above. Passing the global --volume-name flag is
+		// allowed, but would be redundant.
 	}
 
 	// 3 ports are already used by replica server, data server and syncagent server