Adhere to new replica scheduler error convention

Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber · Aug 9, 2023 · d21f226 · d21f226
1 parent e526e41
commit d21f226
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/scheduler/replica_scheduler.go b/scheduler/replica_scheduler.go
@@ -170,7 +170,9 @@ func (rcs *ReplicaScheduler) getDiskCandidates(nodeInfo map[string]*longhorn.Nod
 
 	diskSoftAntiAffinity, err := rcs.ds.GetSettingAsBool(types.SettingNameReplicaDiskSoftAntiAffinity)
 	if err != nil {
-		logrus.Errorf("Error getting replica disk soft anti-affinity setting: %v", err)
+		err = errors.Wrapf(err, "failed to get %v setting", types.SettingNameReplicaDiskSoftAntiAffinity)
+		multiError.Append(util.NewMultiError(err.Error()))
+		return map[string]*Disk{}, multiError
 	}
 	if volume.Spec.ReplicaDiskSoftAntiAffinity != longhorn.ReplicaDiskSoftAntiAffinityDefault &&
 		volume.Spec.ReplicaDiskSoftAntiAffinity != "" {