Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of LICENSE from GPL to Apache #123

Merged
merged 2 commits into from
May 10, 2024
Merged

Change of LICENSE from GPL to Apache #123

merged 2 commits into from
May 10, 2024

Conversation

ekiefl
Copy link
Owner

@ekiefl ekiefl commented Apr 29, 2024

Hi @chaochaodev, @edoson, @kerby2000, and @zhaodong-wang

I'm proposing to change pooltool's license from GPLv3 to Apache 2.0. Apache 2.0 is a popular and more permissive license than GPLv3, allowing greater flexibility in how pooltool can be used and incorporated into other projects.

Important: As contributors to pooltool, your agreement is needed for this change.

Please reply to this PR with:

"I approve" if you agree with the license change.
Your concerns if you have any objections.

Thank you for your time and consideration. Additionally, thanks for your past and hopefully future contributions to pooltool!

@zhaodong-wang
Copy link
Contributor

Thanks for the updates! I approve this change

@ekiefl
Copy link
Owner Author

ekiefl commented May 3, 2024

Anyone else? @chaochaodev, @edoson, @kerby2000

@chaochaodev
Copy link
Contributor

chaochaodev commented May 3, 2024 via email

@kerby2000
Copy link
Collaborator

I approve.

@XmanGB32

This comment has been minimized.

@ekiefl
Copy link
Owner Author

ekiefl commented May 10, 2024

The only contributor who hasn't agreed (or disagreed) is @edoson. Though I was hopeful to get everyone's formal approval, I think we're good to move forward regardless.

@edoson has contributed a small amount to the codebase (784c9dc and 9f1f3bc), but his code was reimplemented by me in the pull request that his commits belonged to (#55), such that as it stands today, there are no lines attributed to him in the git blame of the main branch. In this sense whatever @edoson contributed was re-implemented by me.

Thanks for everyone's cooperation, and I hope you all contribute to pooltool in the future.

@ekiefl ekiefl merged commit 1bfa8f6 into main May 10, 2024
2 checks passed
@ekiefl ekiefl deleted the apache-license branch May 10, 2024 05:10
@ekiefl
Copy link
Owner Author

ekiefl commented Jul 14, 2024

Hello again. I am compiling metadata for the project and would like to include all the contributors as authors, if they are interested.

The section I am filling out is for the package manager poetry (section here) and requires authors to have a name and email.

If you are interested in being included in poetry's author metadata, please respond with your name and email. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants