Use poetry #124
Merged
Use poetry #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pretty sure this is vestigial
When packaged, poetry will wrap up main.py into a CLI tool
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces poetry
Poetry is a popular dependency and package building tool for python. Currently package building is a manual process (see
PYPI.md) and dependency management is controlled withrequirements.txtfiles (requirements.txt,requirements-dev,docs/requirements.txt).Adopting poetry in pooltool has several benefits. Checked items are benefits that come to fruition in this PR, and unchecked benefits are for future PRs.
pip install pooltool-billiards, regardless of OS.Note: this PR has no influence on the pooltool-billiards package on pypi.