Skip to content

Add TP A-14 speed-dependent ball-ball friction #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

derek-mcblane
Copy link
Collaborator

I'd like to add a friction sub-model to the FrictionalInelastic ball-ball collision model. Haven't gotten sub-model configuration working.

This does work with the default a, b, c, parameters.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.42%. Comparing base (89d19a0) to head (522d4c6).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...ll_ball/frictional_inelastic/friction/alciatore.py 46.66% 8 Missing ⚠️
...resolve/ball_ball/frictional_inelastic/__init__.py 55.55% 4 Missing ⚠️
...all_ball/frictional_inelastic/friction/__init__.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   44.22%   44.42%   +0.19%     
==========================================
  Files         127      130       +3     
  Lines        8551     8585      +34     
==========================================
+ Hits         3782     3814      +32     
- Misses       4769     4771       +2     
Flag Coverage Δ
service 44.42% <69.56%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-mcblane derek-mcblane force-pushed the alciatore-ball-ball-friction branch from 39e2f7c to 84029dc Compare December 31, 2024 04:06
@ekiefl
Copy link
Owner

ekiefl commented Jan 7, 2025

There is an active branch that incorporates this idea (#171)

@ekiefl ekiefl closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants