[REFACTORING]: refactoring of the imports and duplicated components #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaYasn
force-pushed
the
refactor/ISSUE-72/code-duplication-2
branch
from
12d79a6 to
3a17a0c
Compare
OlgaYasn
force-pushed
the
refactor/ISSUE-72/code-duplication-2
branch
3 times, most recently
from
205bd27 to
626bce9
Compare
…ared-ui and core-logic
OlgaYasn
force-pushed
the
refactor/ISSUE-72/code-duplication-2
branch
from
626bce9 to
656be7b
Compare
OlgaYasn
force-pushed
the
refactor/ISSUE-72/code-duplication-2
branch
from
656be7b to
89c434a
Compare
OlgaYasn
commented
Feb 5, 2025
| @@ -39,27 +37,16 @@ const SERVER_ENV_CONFIGURATION = { | |||
| /** | |||
| * Get the current context of the server. | |||
| */ | |||
| const getCurrentContext = () => (execEnv?.includes('--dev') ? 'development' : 'production'); | |||
| const currentContext = getEnvironmentContext(); | |||
OlgaYasn
commented
Feb 5, 2025
| import { ServerConfigType, ServerEnvConfigType } from '../types/ServerConfigType.ts'; | ||
| import { getEnvironmentContext } from './getEnvironmentContext.ts'; | ||
|
|
||
| export const getServerConfig = ( |
There was a problem hiding this comment.
Garder que getServerConfig sans exposer getEnvContext
OlgaYasn
commented
Feb 5, 2025
| @@ -1,4 +1,4 @@ | |||
| import { AppLogger, ServerUtils } from '@v6y/core-logic'; | |||
| import { AppLogger, CorsOptions, ServerUtils } from '@v6y/core-logic'; | |||
There was a problem hiding this comment.
Ajouter à getServerConfig
OlgaYasn
commented
Feb 5, 2025
| try { | ||
| if (!dependencies?.length) { | ||
| if (!data?.length) { |
There was a problem hiding this comment.
Add to @Core-Logic : core avec zipUtils, FileUtils... Rename CsvUtils -> exportDataToCsv
OlgaYasn
force-pushed
the
refactor/ISSUE-72/code-duplication-2
branch
from
a386601 to
3bdf44a
Compare
OlgaYasn
force-pushed
the
refactor/ISSUE-72/code-duplication-2
branch
from
7086b83 to
c0e8c70
Compare
OlgaYasn
added
PR in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
✨ Title
📄 Description
Please explain in detail what this PR does, why it is needed, and how it addresses a specific problem. Include any relevant context and background information.
✅ Checklist
🔗 Contextual Links (optional)
Add any relevant links to tracking tickets, previous discussions, or other resources.
📸 Visuals (optional)
If possible, include images or videos that show the result of your changes.
🔍 Reviewers
Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).