Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid year range error #49

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

ekkolon
Copy link
Owner

@ekkolon ekkolon commented Feb 6, 2024

Closes #22

📑 Description

Previously, attempts to utilize commands with the --year flag or parsing the .licensarc configuration file would result in errors due to mishandling of the YYYY-present format for license years.

Changes Made:

  • Resolved the issue where errors occurred during the execution of CLI commands utilizing the --year flag.
  • Fixed parsing errors encountered when reading license year periods from the .licensarc configuration file.
  • Added custom LicenseYearError enum

Fixes:

  • CLI commands now properly handle the --year flag, ensuring correct (de)serialization and parsing of license years.
  • Parsing of license year periods from the .licensarc configuration file has been rectified, preventing errors and ensuring accurate interpretation of YYYY-present format.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@ekkolon ekkolon changed the title Fix/invalid year range error fix: invalid year range error Feb 6, 2024
@ekkolon ekkolon merged commit b176548 into main Feb 6, 2024
6 checks passed
@ekkolon ekkolon deleted the fix/invalid-year-range-error branch February 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cli): invalid year range error when using 'to present' format (e.g 2023-present)
1 participant