Skip to content

Added preact #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added preact #3

wants to merge 1 commit into from

Conversation

eser
Copy link

@eser eser commented Apr 11, 2024

Since preact doesn't support streaming renders, I hesitated to implement this one considering it's very primitive comparing to React's streaming SSR. So I wouldn't care if you close the PR without merging it.

image

@eknkc eknkc mentioned this pull request Apr 11, 2024
@JoviDeCroock
Copy link

JoviDeCroock commented Apr 12, 2024

It doesn't look like the benchmark is using Suspense so I don't think streaming yes or no should make that much of a difference. That being said we did have a preliminary implementation of streaming in preact-render-to-string 😅 would love to see this land in general. According to the README there are others that don't use streaming so I do think it's fair to land this!

As this repository seems central to React (originating from the next discussion) it might be good to show that we are 2x faster and keep React as the baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants