[WIP] PR previews v2 #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(In the English version, for now. Translations can be contributed via Crowdin.)
I imagine it's confusing for folks that are new to the command line as to why their mouse isn't working when they try to move the cursor.
Runcode no longer offers a free tier, so it's best to avoid this.
Remove Runcode instructions
The contributing guidelines are located in the main README.md and not in a separate file. This will align the German translation with the English one.
This will replace the wrong reference to `.html` files with `.md` files. The static page generator will take care of correctly replacing the file extensions while generating the page.
This will add images which are reference to in the markdown files but are not present. The files are copies from the English translation. I would guess it's better to have English pictures than none.
Minor fixes (broken links, missing images)
ekohl
force-pushed
the
generate-pr-preview-v2
branch
2 times, most recently
from
f969848 to
c437772
Compare
|
The PR preview for 458b681 is available at ekohl-tutorial-preview-pr-10.surge.sh No diff compared to the current website |
ekohl
force-pushed
the
generate-pr-preview-v2
branch
from
c437772 to
3263471
Compare
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
add note about editing commands
instructions to create github access token
Update versions
…rial Updating tutorial
…rial-v2 renaming OS X to macOS and updating references
On Ubuntu the file /usr/bin/rename is managed through alternatives because there are multiple implementations. It appears that awalsh128/cache-apt-pkgs-action doesn't update alternatives when a package is cached which means /usr/bin/rename isn't present. The latest image will change to 24.04 on between December and January but on 24.04 there is rename.ul from util-linux which also provides the rename. That avoids the need to rely on awalsh128/cache-apt-pkgs-action for it and the alternatives interaction.
Use Ubuntu 24.04 for rename from util-linux
Install rename in Github deploy workflow
Fixed typo in italian translation
Update README.md with Open in Codeanywhere button
…-update-status Update and cleanup of the tutorial after the update to newer python/django versions
When a contributor submits a PR, we always perform a build. This takes it a step further and uploads that a custom surge.sh domain. It adds a sticky comment to link to that preview while also generating some diffs. This means reviews easier. In the implementation an additional preview step is added. This first builds the base (target of the PR) as the current. Then it downloads the generated preview that was added as an artifact in the original build step. Creating a reasonably sized diff was tricky, because there's a long Javascript line that includes the mtime, making it indeterministic. That line isn't relevant anyway, so it's removed. The diff command also ignores the search index. All of that is placed in the preview, making it readable. A sticky comment is added with a summary, making it easy to use. The sticky comment is updated for every push, rather than added a comment for every push. This keeps the PR conversation usable.
ekohl
force-pushed
the
generate-pr-preview-v2
branch
from
3263471 to
5b66051
Compare
ekohl
force-pushed
the
generate-pr-preview-v2
branch
from
7da3967 to
458b681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.