Skip to content

Fix Dropped Generate Error#8682

Open
alrs wants to merge 1 commit intoeksctl-io:mainfrom
alrs:generate-err
Open

Fix Dropped Generate Error#8682
alrs wants to merge 1 commit intoeksctl-io:mainfrom
alrs:generate-err

Conversation

@alrs
Copy link
Contributor

@alrs alrs commented Feb 24, 2026

This fixes a dropped err variable in pkg/goformation/generate. The function signature does not include an error return, so as with other errors in the function this prints a message about the error, prints the error, and exits on status 1.

Because the property variable being operated on is more complicated than a simple string, I marshaled it with the already-imported encoding/json package to make it human-readable. Every field in the struct is exported, so json marshaling works in this case.

@github-actions
Copy link
Contributor

Hello alrs 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants