Fix CI build failures: resolve ESLint errors and formatting issues #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes failing CI builds by addressing code quality issues that were preventing the pipeline from passing. The changes are minimal and surgical, focusing only on the blocking errors without modifying functional code.
Issues Fixed
1. ESLint Errors (2 blocking errors)
tests/cli/index.test.ts(lines 41 and 83)@typescript-eslint/prefer-nullish-coalescingwas violated||) with nullish coalescing (??) operatorBefore:
After:
2. Prettier Formatting Issues
tests/cli/index.test.tsnpm run formatValidation
All CI quality gates now pass:
Impact
The changes align with the project's preference for nullish coalescing over logical OR when dealing with potentially null/undefined values, providing more predictable behavior when
codeis0(falsy but valid exit code).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.