Skip to content

Commit

Permalink
Change diff reference for admin UI check
Browse files Browse the repository at this point in the history
Previously, this was pointing to the file from the base commit
of the PR. While this works fine for PRs that target the "main"
branch, when a PR targets any other branch, we'll want to reference
the branch's name rather than a specific commit SHA.

At least that's what I think is going on.
  • Loading branch information
owi92 committed Dec 16, 2024
1 parent 606d792 commit 163ff9a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/check-admin-ui-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
npx graphql-inspector diff \
--rule .github/workflows/check-admin-ui-api/rule.js \
--onComplete .github/workflows/check-admin-ui-api/onComplete.js \
git:${{ github.event.pull_request.base.sha }}:frontend/src/schema.graphql \
git:${{ github.event.pull_request.base.ref }}:frontend/src/schema.graphql \
git:${{ github.event.pull_request.head.sha }}:frontend/src/schema.graphql \
| tee >( \
grep -v ^::set-output \
Expand Down

0 comments on commit 163ff9a

Please sign in to comment.