Move modal components to appkit #1170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the "Modal" component to our appkit library and import it from there. This should result in zero functional changes.
Moves the basic styled button, as well as its styling method, to appkit.
Spinner was already migrated to appkit, but presumably not used because of color scheme reasons. Since there are now color schemes in appkit, it should be fine to use appkits spinner and get rid of our own.
Moves only the error box (not error page) to appkit. This also requires moving Card to appkit.
Moves the ConfirmationModal component to Appkit.
|
This pull request has conflicts ☹ |
github-actions
bot
added
the
status:conflicts
|
Replaced by #1199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, as this depends on a new opencast/appkit release including opencast/appkit#5
Moves the
ModalandConfirmationModalcomponents and their types to appkit. Also moves a bunch of other stuff thatConfirmationModalin particular requires. Should result in zero functional changes (for now).