[common] [arcana] Resolve potential race condition in crafting_magic_routine #7038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahtraDR
reviewed
Jan 3, 2025
Comment on lines
+839
to
844
| if checkcastrt > 0 | ||
| return | ||
| elsif !XMLData.prepared_spell.eql?('None') && checkcastrt == 0 | ||
| spell = XMLData.prepared_spell | ||
| data = training_spells.find { |_skill, info| info['name'] == spell }.last | ||
| crafting_cast_spell(data, settings) |
There was a problem hiding this comment.
Suggested change
| if checkcastrt > 0 | |
| return | |
| elsif !XMLData.prepared_spell.eql?('None') && checkcastrt == 0 | |
| spell = XMLData.prepared_spell | |
| data = training_spells.find { |_skill, info| info['name'] == spell }.last | |
| crafting_cast_spell(data, settings) | |
| unless XMLData.prepared_spell.eql?('None') && checkcastrt == 0 | |
| return | |
| else | |
| spell = XMLData.prepared_spell | |
| data = training_spells.find { |_skill, info| info['name'] == spell }.last | |
| crafting_cast_spell(data, settings) |
There was a problem hiding this comment.
It seems to me we want to return in all cases where we have no spell prepped. If that's correct, I prefer an unless else, versus and if/elsif not.
There was a problem hiding this comment.
It seems to me we want to return in all cases where we have no spell prepped. If that's correct, I prefer an unless else, versus and if/elsif not.
No, we want to fall through to preparing a spell if none are prepared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.