[common] [arcana] Resolve potential race condition in crafting_magic_routine #7038
Conversation
| if checkcastrt > 0 | ||
| return | ||
| elsif !XMLData.prepared_spell.eql?('None') && checkcastrt == 0 | ||
| spell = XMLData.prepared_spell | ||
| data = training_spells.find { |_skill, info| info['name'] == spell }.last | ||
| crafting_cast_spell(data, settings) |
There was a problem hiding this comment.
| if checkcastrt > 0 | |
| return | |
| elsif !XMLData.prepared_spell.eql?('None') && checkcastrt == 0 | |
| spell = XMLData.prepared_spell | |
| data = training_spells.find { |_skill, info| info['name'] == spell }.last | |
| crafting_cast_spell(data, settings) | |
| unless XMLData.prepared_spell.eql?('None') && checkcastrt == 0 | |
| return | |
| else | |
| spell = XMLData.prepared_spell | |
| data = training_spells.find { |_skill, info| info['name'] == spell }.last | |
| crafting_cast_spell(data, settings) |
There was a problem hiding this comment.
It seems to me we want to return in all cases where we have no spell prepped. If that's correct, I prefer an unless else, versus and if/elsif not.
There was a problem hiding this comment.
It seems to me we want to return in all cases where we have no spell prepped. If that's correct, I prefer an unless else, versus and if/elsif not.
No, we want to fall through to preparing a spell if none are prepared.
There was a problem hiding this comment.
Any further comment? AFAIK it should be good to merge
There was a problem hiding this comment.
Sorry, this one went awry. Can you please file it against https://github.com/elanthia-online/lich-5/blob/staging/lib/dragonrealms/commons/common-arcana.rb
No description provided.