[script][combat-trainer] Another necro fix - missing messages for using-corpse Flag

[mdr55]

The using-corpse Flag is used to suppressed the double ritual/skinning from happening due to short loot timers and bodies not decomposing quickly enough. However the Flag was missing messages for dissect and butcher (was ok on other messages like preserve), which meant the suppression didn't work in those cases.

[mdr55]

WARNING: Supppressing Brawling due to skill not training
[combat-trainer]>get my hand.sickle
You get a farmer's hand sickle composed of iron from inside your carryall.

[combat-trainer: Delay from SetupProcess]
[combat-trainer: Timer: 0.402641895]
[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 0.000188923]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 0.000118801]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 0.000105532]
[combat-trainer]>health
Your body feels at full strength.
Your spirit feels full of life.
You are slightly fatigued.
You have some minor abrasions to the chest, some minor abrasions to the back.
You have no significant injuries.

[combat-trainer]>stow my hand.sickle

You put your sickle in your carryall.

[combat-trainer]>perform butcher on snowbeast
Since you don't choose a body part to go for, you instead study the snowbeast carefully, and you think that the leg is the best body part to take from this corpse.
You begin to dismember the corpse in front of you.
Making several deep cuts with your knife at key places in the snowbeast's corpse, you manage to extract a poor (1/10) snowbeast leg.
Roundtime: 7 sec.

• Moving in like a timid schoolboy, a snowbeast claws at you. You block with a lumium round sipar.
  [You're nimbly balanced and in superior position.]

• Ineptly, a snowbeast slices wide at you. You block with a lumium round sipar.
  [You're nimbly balanced and in good position.]

You feel fully rested.

[combat-trainer]>drop my snowbeast leg

• As if effort and skill were a bad thing, a snowbeast claws at you. You block with a lumium round sipar.
  [You're nimbly balanced and in better position.]

You discard the snowbeast leg.

[combat-trainer]>perform dissect on snowbeast
You carefully position the corpse and make a cut across its length, opening up the viscera for your inspection. Using your knife as a probe, you trace the lines of the corpse, cutting into where vital fluids once flowed. You learn something both of the snowbeast and the Great Work through the examination.
Roundtime: 8 sec.

Musician Kvofe just arrived.

Musician Kvofe runs south.

• Awkwardly, a snowbeast claws at you. You fend off most of the claw with a polished steel parry stick.
  [You're nimbly balanced and in better position.]

You feel fully prepared to cast your spell.

• As if fumbling muscle flab were natural, a snowbeast claws at you. You block with a lumium round sipar.
  [You're nimbly balanced and in better position.]

• Ineptly, a snowbeast slices wide at you. You block with a lumium round sipar.
  [You're nimbly balanced and in good position.]

• Apparently without direction or thought, a snowbeast claws at you. You counter most of the claw with a polished steel parry stick.
  [You're nimbly balanced and have slight advantage.]

[combat-trainer]>get my hand.sickle
Katamba slowly rises above the horizon.

You get a farmer's hand sickle composed of iron from inside your carryall.

[combat-trainer]>loot treasure
You search the snowbeast.
You find nothing of interest.

[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 18.396016229]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 8.828e-05]
[combat-trainer: Delay from TrainerProcess]
[combat-trainer: Timer: 0.00042003]
[combat-trainer: A1]
[combat-trainer: Timer: 8.6394e-05]
[combat-trainer: A2]
[combat-trainer: Timer: 0.000136541]
[combat-trainer]>feint
You turn to face a snowbeast.
< Moving with indomitable grace, you feint a farmer's hand sickle composed of iron at a snowbeast. A snowbeast fails to evade, failing miserably. The sickle lands a good strike (3/23) to the snowbeast's abdomen.
[You're adeptly balanced and in superior position.]
[Roundtime 1 sec.]

Musician Kvofe just arrived.

Musician Kvofe runs northeast.

• Awkwardly, a snowbeast claws at you. You turn aside most of the claw with a farmer's hand sickle composed of iron.
  [You're adeptly balanced and in excellent position.]

[combat-trainer: Delay from AttackProcess]
[combat-trainer: Timer: 1.406005367]
[combat-trainer: END OF PROCESS PASS]
[combat-trainer: STARTING]
[combat-trainer: Timer: 0.100710219]
[combat-trainer: updated @no_gain_list: {"Brawling"=>6, "Small Edged"=>0}]
[combat-trainer: Delay from SetupProcess]
[combat-trainer: Timer: 0.000316733]
[combat-trainer]>harness 18
You tap into the mana from eighteen of the surrounding streams and attempt to keep it channeling in a stream around you.
Roundtime: 3 sec.

[combat-trainer]>harness 18

• As if effort and skill were a bad thing, a snowbeast claws at you. You block solidly with a lumium round sipar.
  [You're adeptly balanced and in superior position.]

You tap into the mana from eighteen of the surrounding streams and add it to the generous amount already streaming around you.
Roundtime: 3 sec.

• Awkwardly, a snowbeast slices wide at you. You beat off most of the claw with a farmer's hand sickle composed of iron.
  [You're nimbly balanced and in excellent position.]

[combat-trainer]>cast
You gesture.
You contribute your harnessed streams to increase the pattern's potential.
Pale yellow sparks flicker around your torso. Your possessions suddenly feel lighter and easier to carry.

[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 6.245294546]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 0.000113284]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 0.000151138]
[combat-trainer]>health
Your body feels at full strength.
Your spirit feels full of life.
You are slightly fatigued.
You have some minor abrasions to the chest, some minor abrasions to the back.
You have no significant injuries.

[combat-trainer]>stow my hand.sickle
You put your sickle in your carryall.

[combat-trainer]>perform butcher on snowbeast

• Awkwardly, a snowbeast claws at you. You block with a lumium round sipar.
  [You're nimbly balanced and in better position.]

A snowbeast sniffs at the ground and licks its fangs.

A failed or completed ritual has rendered this corpse unusable for your purposes.

[combat-trainer]>perform dissect on snowbeast
A failed or completed ritual has rendered this corpse unusable for your purposes.

[combat-trainer]>get my hand.sickle
You get a farmer's hand sickle composed of iron from inside your carryall.

[combat-trainer]>arrange for skin
You feel fully rested.

Arrange what?

[combat-trainer]>dissect snowbeast
A failed or completed ritual has rendered this corpse unusable for your purposes.

[combat-trainer]>tap my bundle
You tap a tight bundle that you are wearing.

[combat-trainer]>skin
Skin what?

A snowbeast's body folds up into itself and turns to dust.

[combat-trainer]>loot treasure
I could not find what you were referring to.

[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 5.41704461]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 0.000143176]
[combat-trainer]>circle

• Awkwardly, a snowbeast slices wide at you. You block with a lumium round sipar.
  [You're nimbly balanced and in dominating position.]

You fake a snowbeast, first moving one way and then another, leaving it off balance.
[You're adeptly balanced and overwhelming opponent.]
Roundtime: 3 sec.

• Apparently without direction or thought, a snowbeast claws at you. You block with a lumium round sipar.
  [You're adeptly balanced and in very strong position.]

Before fix: See the 2nd set of attempted necro + skin/dissect actions.

[mdr55]

[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 1.106428624]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 0.0001371]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 9.5404e-05]
[combat-trainer]>health
Your body feels at full strength.
Your spirit feels full of life.
You have some minor abrasions to the chest, some minor abrasions to the back.
You have no significant injuries.

[combat-trainer]>stow my hand.sickle
You put your sickle in your carryall.

[combat-trainer]>perform butcher on snowbeast
Since you don't choose a body part to go for, you instead study the snowbeast carefully, and you think that the leg is the best body part to take from this corpse.
You begin to dismember the corpse in front of you.
Making several deep cuts with your knife at key places in the snowbeast's corpse, you manage to extract a passable (3/10) snowbeast leg.
Roundtime: 7 sec.

[combat-trainer]>drop my snowbeast leg
You discard the snowbeast leg.

[combat-trainer]>perform dissect on snowbeast
You carefully position the corpse and make a cut across its length, opening up the viscera for your inspection. Using your knife as a probe, you trace the lines of the corpse, cutting into where vital fluids once flowed. You learn something both of the snowbeast and the Great Work through the examination.
Roundtime: 8 sec.

[combat-trainer]>get my hand.sickle
You get a farmer's hand sickle composed of iron from inside your carryall.

[combat-trainer]>loot treasure
You search the snowbeast.
You find nothing of interest.

[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 17.09199548]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 8.7303e-05]
[combat-trainer: Delay from TrainerProcess]
[combat-trainer: Timer: 0.000366112]
[combat-trainer: A1]
[combat-trainer: Timer: 7.1169e-05]

[combat-trainer: Delay from AttackProcess]
[combat-trainer: Timer: 1.000493944]
[combat-trainer: END OF PROCESS PASS]
[combat-trainer: STARTING]
[combat-trainer: Timer: 0.100597005]
[combat-trainer: Delay from SetupProcess]
[combat-trainer: Timer: 0.000250384]
[combat-trainer]>prepare ease 1
That won't affect your current attunement very much.
With tense movements you prepare your body for the Ease Burden spell.

[combat-trainer]>charge my cambrinth armband 18
You harness a moderate amount of energy and attempt to channel it into your cambrinth armband.
You are able to channel all the energy into the armband.
The cambrinth armband absorbs all of the energy.
Roundtime: 4 sec.

[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 4.194950846]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 0.000115379]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 0.000641709]
[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 0.000948873]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 5.0635e-05]
[combat-trainer: Delay from TrainerProcess]
[combat-trainer: Timer: 0.000571098]
[combat-trainer: A1]
[combat-trainer: Timer: 3.7505e-05]
[combat-trainer: Delay from AttackProcess]
[combat-trainer: Timer: 1.000646408]
[combat-trainer: END OF PROCESS PASS]
[combat-trainer: STARTING]
[combat-trainer: Timer: 0.100378399]
[combat-trainer: Delay from SetupProcess]
[combat-trainer: Timer: 0.000249057]
[combat-trainer]>charge my cambrinth armband 18

You harness a moderate amount of energy and attempt to channel it into your cambrinth armband.
You are able to channel all the energy into the armband.
The cambrinth armband resists, only absorbing part of the energy while the rest dissipates harmlessly.
Roundtime: 3 sec.

[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 2.896086471]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 0.00041989]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 0.000116775]
[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 0.001073611]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 8.9258e-05]
[combat-trainer: Delay from TrainerProcess]
[combat-trainer: Timer: 0.00037156]
[combat-trainer: A1]
[combat-trainer: Timer: 6.3416e-05]
Broken Doll Nebros just arrived.

Broken Doll Nebros went through a small crevice in the ice just behind the waterfall.

[combat-trainer: Delay from AttackProcess]
[combat-trainer: Timer: 1.000292938]
[combat-trainer: END OF PROCESS PASS]
[combat-trainer: STARTING]
[combat-trainer: Timer: 0.100547137]
[combat-trainer: Delay from SetupProcess]
[combat-trainer: Timer: 0.000273012]
[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 0.000149393]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 0.00016797]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 0.00010595]
[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 0.002031284]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 8.2065e-05]
[combat-trainer: Delay from TrainerProcess]
[combat-trainer: Timer: 0.000244796]
[combat-trainer: A1]
[combat-trainer: Timer: 5.769e-05]
[combat-trainer: Delay from AttackProcess]
[combat-trainer: Timer: 1.000492407]
[combat-trainer: END OF PROCESS PASS]

After fix. After the initial butcher & dissect, you can see that there was further attempts to do corpse actions in the next few cycles.

[mdr55]

Closing this PR. The use of the Flag in the first place was an imperfect response to the fact we can't differentiate corpses + use of the loot timer. The issue identified in this PR is a side effect that favoured high level necros who can drop multiple bodies. By masking it here it helps low level necros but prevents high level necros from ritualing multiple bodies. The options here are:

1. tackle the issue closer to the root cause
2. add in a yaml option - say "necro_timer_mask" to switch between which rituals the Flag masks.
3. leave as existing