[script][combat-trainer] YACTOM: offhand_gain_check #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahtraDR
requested changes
Jan 26, 2025
Co-authored-by: Mahtra <93822896+MahtraDR@users.noreply.github.com>
to align with base yaml
MahtraDR
reviewed
Jan 26, 2025
MahtraDR
reviewed
Jan 26, 2025
MahtraDR
reviewed
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offhand_gain_check is a feature that is activated by combat_trainer_offhand_gain_check: value in the yaml (suggested value of 2)
Its the offhand equivalent of the gain_check feature that was merged in PR #7068 - it will switch offhand weapons when they stop gaining.
This PR also contains a fix for a non-fatal edge case affecting gain_check (most weapons blacklisted + remainder at 34)
more details in code comments