Skip to content

Commit

Permalink
Merge branch 'main' into fix/baggage-prefix-on-labels
Browse files Browse the repository at this point in the history
  • Loading branch information
Mpdreamz authored Nov 15, 2023
2 parents 9cb2439 + edf2bc1 commit a5f5d08
Show file tree
Hide file tree
Showing 45 changed files with 1,356 additions and 610 deletions.
11 changes: 10 additions & 1 deletion .ci/updatecli.d/update-gherkin-specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,15 @@ sources:
transformers:
- findsubmatch:
pattern: "[0-9a-f]{40}"

pull_request:
kind: shell
dependson:
- sha
spec:
command: gh api /repos/elastic/apm/commits/{{ source "sha" }}/pulls --jq '.[].html_url'
environments:
- name: GITHUB_TOKEN
- name: PATH
api_key.feature:
kind: file
spec:
Expand Down Expand Up @@ -65,6 +73,7 @@ actions:
### Why
*Changeset*
* https://github.com/elastic/apm/commit/{{ source "sha" }}
* {{ source "pull_request" }}
targets:
api_key.feature:
Expand Down
11 changes: 10 additions & 1 deletion .ci/updatecli.d/update-json-specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,15 @@ sources:
transformers:
- findsubmatch:
pattern: "[0-9a-f]{40}"

pull_request:
kind: shell
dependson:
- sha
spec:
command: gh api /repos/elastic/apm/commits/{{ source "sha" }}/pulls --jq '.[].html_url'
environments:
- name: GITHUB_TOKEN
- name: PATH
container_metadata_discovery.json:
kind: file
spec:
Expand Down Expand Up @@ -69,6 +77,7 @@ actions:
### Why
*Changeset*
* https://github.com/elastic/apm/commit/{{ source "sha" }}
* {{ source "pull_request" }}
targets:
container_metadata_discovery.json:
Expand Down
10 changes: 10 additions & 0 deletions .ci/updatecli.d/update-specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ sources:
transformers:
- findsubmatch:
pattern: "[0-9a-f]{40}"
pull_request:
kind: shell
dependson:
- sha
spec:
command: gh api /repos/elastic/apm-data/commits/{{ source "sha" }}/pulls --jq '.[].html_url'
environments:
- name: GITHUB_TOKEN
- name: PATH
error.json:
kind: file
spec:
Expand Down Expand Up @@ -60,6 +69,7 @@ actions:
### Why
*Changeset*
* https://github.com/elastic/apm-data/commit/{{ source "sha" }}
* {{ source "pull_request" }}
targets:
error.json:
Expand Down
2 changes: 2 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ resharper_csharp_accessor_owner_body=expression_body
resharper_redundant_case_label_highlighting=do_not_show
resharper_redundant_argument_default_value_highlighting=do_not_show

dotnet_diagnostic.IDE0057.severity = none

[*.{sh,bat,ps1}]
trim_trailing_whitespace=true
insert_final_newline=true
Expand Down
216 changes: 111 additions & 105 deletions ElasticApmAgent.sln

Large diffs are not rendered by default.

130 changes: 130 additions & 0 deletions benchmarks/Elastic.Apm.Benchmarks/CgroupMetricsProviderBenchmarks.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
// Licensed to Elasticsearch B.V under one or more agreements.
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information

using System.Collections.Generic;
using System.IO;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Engines;
using Elastic.Apm.Helpers;
using Elastic.Apm.Metrics.MetricsProvider;
using Elastic.Apm.Tests.Utilities;
using static Elastic.Apm.Metrics.MetricsProvider.CgroupMetricsProvider;
using static Elastic.Apm.Tests.TestHelpers.CgroupFileHelper;

namespace Elastic.Apm.Benchmarks;

[MemoryDiagnoser]
public class CgroupMetricsProviderBenchmarks
{
private CgroupPaths _cgroupPaths;
private CgroupMetricsProvider _cgroupMetricsProvider;
private readonly Consumer _consumer = new();

[GlobalSetup]
public void Setup()
{
_cgroupPaths = CreateDefaultCgroupFiles(CgroupVersion.CgroupV2);
_cgroupMetricsProvider = TestableCgroupMetricsProvider(new NoopLogger(), new List<WildcardMatcher>(), _cgroupPaths.RootPath, true);
}

[GlobalSetup(Target = nameof(GetSamplesUnlimited))]
public void SetupUnlimited()
{
_cgroupPaths = CreateDefaultCgroupFiles(CgroupVersion.CgroupV2);
UnlimitedMaxMemoryFiles(_cgroupPaths);
_cgroupMetricsProvider = TestableCgroupMetricsProvider(new NoopLogger(), new List<WildcardMatcher>(), _cgroupPaths.RootPath, true);
}

private static void UnlimitedMaxMemoryFiles(CgroupPaths paths)
{
if (paths.CgroupVersion == CgroupVersion.CgroupV1)
{
using var sr = new StreamWriter(File.Create(Path.Combine(paths.CgroupV1MemoryControllerPath, "memory.limit_in_bytes")));
sr.WriteAsync($"9223372036854771712\n");
}

if (paths.CgroupVersion == CgroupVersion.CgroupV2)
{
using var sr = new StreamWriter(File.Create(Path.Combine(paths.CgroupV2SlicePath, "memory.max")));
sr.WriteAsync($"max\n");
}
}

[GlobalCleanup]
public void Cleanup()
=> Directory.Delete(_cgroupPaths.RootPath, true);

[Benchmark]
public void GetSamples()
{
foreach (var metricSet in _cgroupMetricsProvider.GetSamples())
{
metricSet.Samples.Consume(_consumer);
}
}

// WINDOWS:
//| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Allocated | Alloc Ratio |
//|-------------------- |---------:|--------:|---------:|---------:|--------:|-------:|----------:|------------:|
//| GetSamplesOriginal | 433.0 us | 8.39 us | 11.20 us | baseline | | 1.9531 | 29.4 KB | |
//| GetSamplesOptimised | 409.9 us | 5.11 us | 4.53 us | -5% | 3.0% | - | 1.47 KB | -95% |

// WINDOWS: After yield return
//| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Allocated | Alloc Ratio |
//|-------------------- |---------:|--------:|---------:|---------:|--------:|-------:|----------:|------------:|
//| GetSamplesOriginal | 429.1 us | 8.08 us | 13.93 us | baseline | | 1.9531 | 29.44 KB | |
//| GetSamplesOptimised | 419.7 us | 6.83 us | 6.39 us | -5% | 3.3% | - | 1.46 KB | -95% |

// WINDOWS: Remove metric
//| Method | Mean | Error | StdDev | Allocated | Alloc Ratio |
//|-------------------- |---------:|--------:|--------:|----------:|------------:|
//| GetSamples | 296.9 us | 3.46 us | 3.23 us | 1.05 KB | -96% |

// LINUX: After yield return
//| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Gen1 | Allocated | Alloc Ratio |
//|-------------------- |---------:|----------:|----------:|---------:|--------:|-------:|-------:|----------:|------------:|
//| GetSamplesOriginal | 9.643 us | 0.1600 us | 0.1418 us | baseline | | 2.3346 | 0.0610 | 29328 B | |
//| GetSamplesOptimised | 5.525 us | 0.0580 us | 0.0569 us | -43% | 1.6% | 0.0534 | - | 680 B | -98% |

// LINUX: Remove metric
//| Method | Mean | Error | Ratio | StdDev | Gen0 | Allocated | Alloc Ratio |
//|-------------------- |---------:|----------:|---------:|----------:|-------:|----------:| |
//| GetSamples | 4.363 us | 0.0458 us | -55% | 0.0382 us | 0.0381 | 496 B | -98% |

[Benchmark]
public void GetSamplesUnlimited()
{
foreach (var metricSet in _cgroupMetricsProvider.GetSamples())
{
metricSet.Samples.Consume(_consumer);
}
}

// WINDOWS:
//| Method | Mean | Error | StdDev | Gen0 | Allocated |
//|-------------------- |---------:|--------:|--------:|-------:|----------:|
//| GetSamplesUnlimited | 467.1 us | 9.28 us | 9.11 us | 0.4883 | 9.5 KB |

// WINDOWS: Optimised
//| Method | Mean | Error | StdDev | Allocated |
//|-------------------- |---------:|--------:|--------:|----------:|
//| GetSamplesUnlimited | 444.9 us | 8.46 us | 8.69 us | 1.88 KB |

// WINDOWS: Remove metric
//| Method | Mean | Error | StdDev | Allocated | Alloc Ratio |
//|-------------------- |---------:|--------:|--------:|----------:| |
//| GetSamplesUnlimited | 305.4 us | 5.04 us | 4.71 us | 1.43 KB | -85% |

// LINUX: Optimised
//| Method | Mean | Error | StdDev | Gen0 | Allocated |
//|-------------------- |---------:|----------:|----------:|-------:|----------:|
//| GetSamplesUnlimited | 7.217 us | 0.1375 us | 0.1350 us | 0.0687 | 864 B |
//** NOTE: This includes some overhead (176 bytes) for building the test path which is not incurred
//in production. This is there equivient to the limited benchmark when this is taken into account.

// LINUX: Remove metric
//| Method | Mean | Error | StdDev | Gen0 | Allocated |
//|-------------------- |---------:|----------:|----------:|-------:|----------:|
//| GetSamplesUnlimited | 4.908 us | 0.0736 us | 0.0688 us | 0.0534 | 680 B |
}
14 changes: 4 additions & 10 deletions benchmarks/Elastic.Apm.Benchmarks/Elastic.Apm.Benchmarks.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,13 @@
<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
<PackageReference Include="Microsoft.Data.SqlClient" Version="1.1.4" />
<PackageReference Include="Elastic.CommonSchema.BenchmarkDotNetExporter" Version="1.5.0"/>
<PackageReference Include="Elastic.CommonSchema.BenchmarkDotNetExporter" Version="1.5.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="$(SolutionRoot)\test\integrations\applications\SampleAspNetCoreApp\SampleAspNetCoreApp.csproj"/>
<ProjectReference Include="..\..\src\Elastic.Apm\Elastic.Apm.csproj"/>
<ProjectReference Include="..\..\test\Elastic.Apm.Tests.Utilities\Elastic.Apm.Tests.Utilities.csproj"/>
</ItemGroup>

<ItemGroup>
<Content Include="TestResources\**\*.*">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
<ProjectReference Include="$(SolutionRoot)\test\integrations\applications\SampleAspNetCoreApp\SampleAspNetCoreApp.csproj" />
<ProjectReference Include="..\..\src\Elastic.Apm\Elastic.Apm.csproj" />
<ProjectReference Include="..\..\test\Elastic.Apm.Tests\Elastic.Apm.Tests.csproj" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// Licensed to Elasticsearch B.V under one or more agreements.
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information

using System.Collections.Generic;
using System.IO;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Engines;
using Elastic.Apm.Helpers;
using Elastic.Apm.Metrics.MetricsProvider;
using Elastic.Apm.Tests.Utilities;
using static Elastic.Apm.Tests.TestHelpers.CgroupFileHelper;

namespace Elastic.Apm.Benchmarks;

[MemoryDiagnoser]
public class FreeAndTotalMemoryProviderBenchmarks
{
private CgroupPaths _cgroupPaths;
private FreeAndTotalMemoryProvider _freeAndTotalMemoryProvider;
private readonly Consumer _consumer = new();

[GlobalSetup]
public void Setup()
{
_cgroupPaths = CreateDefaultCgroupFiles(CgroupVersion.CgroupV2);
_freeAndTotalMemoryProvider = FreeAndTotalMemoryProvider
.TestableFreeAndTotalMemoryProvider(new NoopLogger(), new List<WildcardMatcher>(), _cgroupPaths.RootPath, true);
}

[GlobalCleanup]
public void Cleanup()
=> Directory.Delete(_cgroupPaths.RootPath, true);

[Benchmark]
public void GetSamples()
{
foreach (var metricSet in _freeAndTotalMemoryProvider.GetSamples())
{
metricSet.Samples.Consume(_consumer);
}
}

// WINDOWS
//| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Allocated | Alloc Ratio |
//|------------------- |---------:|---------:|---------:|---------:|--------:|-------:|----------:|------------:|
//| GetSamplesOriginal | 600.1 ns | 12.00 ns | 17.22 ns | baseline | | 0.0277 | 352 B | |
//| GetSamples | 553.8 ns | 10.57 ns | 12.98 ns | -8% | 3.2% | 0.0162 | 208 B | -41% |

// LINUX
//| Method | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Gen1 | Allocated | Alloc Ratio |
//|------------------- |-----------:|---------:|----------:|---------:|--------:|-------:|-------:|----------:|------------:|
//| GetSamplesOriginal | 3,693.2 ns | 73.86 ns | 108.27 ns | baseline | | 0.7324 | 0.0191 | 9216 B | |
//| GetSamples | 438.7 ns | 8.57 ns | 8.41 ns | -88% | 3.1% | 0.0215 | - | 272 B | -97% |
}
2 changes: 1 addition & 1 deletion benchmarks/Elastic.Apm.Benchmarks/MetricsBenchmarks.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public void CollectTotalCpuTime2X()
[Benchmark]
public void CollectTotalAndFreeMemory2X()
{
var mockPayloadSender = new FreeAndTotalMemoryProvider(new List<WildcardMatcher>());
var mockPayloadSender = new FreeAndTotalMemoryProvider(new NoopLogger(), new List<WildcardMatcher>());

mockPayloadSender.GetSamples();
mockPayloadSender.GetSamples();
Expand Down
15 changes: 13 additions & 2 deletions benchmarks/Elastic.Apm.Benchmarks/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
// See the LICENSE file in the project root for more information

using System;
using System.IO;
using BenchmarkDotNet.Columns;
using BenchmarkDotNet.Configs;
using BenchmarkDotNet.Reports;
using BenchmarkDotNet.Running;
using Elastic.Apm.Benchmarks.Helpers;
using Elastic.CommonSchema.BenchmarkDotNetExporter;
Expand All @@ -14,6 +17,11 @@ public class Program
{
public static void Main(string[] args)
{
//var thing = new FreeAndTotalMemoryProviderBenchmarks();
//thing.Setup();
//thing.GetSamplesOriginal();
//thing.Cleanup();

var esUrl = Environment.GetEnvironmentVariable("ES_URL");
var esPassword = Environment.GetEnvironmentVariable("ES_PASS");
var esUser = Environment.GetEnvironmentVariable("ES_USER");
Expand Down Expand Up @@ -46,8 +54,11 @@ public static void Main(string[] args)
}
}

var exporter = new ElasticsearchBenchmarkExporter(options);
var config = DefaultConfig.Instance.AddExporter(exporter);
//var exporter = new ElasticsearchBenchmarkExporter(options);
var config = DefaultConfig.Instance
//.AddExporter(exporter)
.WithSummaryStyle(new SummaryStyle(null, false, null, null, ratioStyle: RatioStyle.Percentage));

BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args, config);
}
}
Expand Down
21 changes: 21 additions & 0 deletions benchmarks/Elastic.Apm.Profiling/Elastic.Apm.Profiling.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsTestProject>false</IsTestProject>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="JetBrains.Profiler.Api" Version="1.4.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\Elastic.Apm\Elastic.Apm.csproj" />
<ProjectReference Include="..\..\test\Elastic.Apm.Tests\Elastic.Apm.Tests.csproj" />
<ProjectReference Include="..\Elastic.Apm.Benchmarks\Elastic.Apm.Benchmarks.csproj" />
</ItemGroup>

</Project>
Loading

0 comments on commit a5f5d08

Please sign in to comment.