Use TestContainer Cloud on CI for windows tests that can not host the requested images #2139
Conversation
Mpdreamz
changed the title
amannocci
force-pushed
the
feature/windows-profiler-tests
branch
from
5d9ce17 to
22e022c
Compare
|
@Mpdreamz It seems like we are ready to move forward with windows tests using testcontainers cloud. |
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
amannocci
force-pushed
the
feature/windows-profiler-tests
branch
from
3d2244b to
24fe6aa
Compare
There was a problem hiding this comment.
@amannocci pinged me about this, PR looks ok to me. @stevejgordon could you please also look at this, before we merge?
There was a problem hiding this comment.
LGTM, will merge once all test changes pass.
@gregkalapos mind giving this a LGTM? since i amended this commit we need another person to sign off 😄
| - name: Setup Testcontainers Cloud Client | ||
| uses: atomicjar/testcontainers-cloud-setup-action@v1 | ||
| with: | ||
| token: ${{ secrets.TC_CLOUD_TOKEN }} | ||
|
|
There was a problem hiding this comment.
I'm afraid this won't work for forked PRs. Shall this be changed by enabling only when working on the upstream rather than on forked-PRs?
There was a problem hiding this comment.
That would be great @v1v 👍
There was a problem hiding this comment.
Cool, I'll code something. Then likely, I might need your help with skipping those tests for forked PRs.
No description provided.