Skip to content

Update high watermark settings for Elasticsearch Integration tests #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Oct 16, 2023

This improves diagnostic output for testcontainers getting started and ensuring the output of docker and its console out gets pushed out over to xUnit.

Currently only enabled for Elasticsearch.

This allow me to diagnose a failing Elasticsearch integration test that only failed on CI:

As seen here: #2197

Due to the high watermark settings were too high (or low?) to run under the restricted Github Action runner's environment.

@Mpdreamz Mpdreamz changed the title Improve error message when Elasticsearch integration test fails Update high watermark settings for Elasticsearch Integration tests Oct 16, 2023
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mpdreamz Mpdreamz merged commit e6a3d0b into main Oct 16, 2023
@Mpdreamz Mpdreamz deleted the fix/elasticsearch-test-failure-messages branch October 16, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants