Prevent server certificate callback runtime exception #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
force-pushed
the
bug/2212
branch
from
f0fc2ee to
4f6a7e1
Compare
gregkalapos
previously approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Changes LGTM.
We have related docs here: https://github.com/elastic/apm-agent-dotnet/blob/main/docs/configuration.asciidoc
With this PR, VerifyServerCert and ServerCert won't work on net462 anymore - which was problematic anyways, so all intentional.
Do we maybe want to add a note about net462
On .NET Full framework <4.7.2, HttpClientHandler.ServerCertificateCustomValidationCallback is not available. Due to dependency binding issues introduced with netstandard, the incorrect System.Net.Http package may be resolved and lead to exceptions at runtime. This fix prevents calling this API on net462 targets which includes any .NET Framework version < .NET 4.7.2. This introduces the net472 target so that we can resume using this API from that version, where it was included in the box.
stevejgordon
force-pushed
the
bug/2212
branch
from
2d13f23 to
7a2843e
Compare
gregkalapos
approved these changes
Nov 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
* Prevent server certificate callback runtime exception On .NET Full framework <4.7.2, HttpClientHandler.ServerCertificateCustomValidationCallback is not available. Due to dependency binding issues introduced with netstandard, the incorrect System.Net.Http package may be resolved and lead to exceptions at runtime. This fix prevents calling this API on net462 targets which includes any .NET Framework version < .NET 4.7.2. This introduces the net472 target so that we can resume using this API from that version, where it was included in the box. * Update documentation * Tweak docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On .NET Full framework <4.7.2, HttpClientHandler.ServerCertificateCustomValidationCallback is not available. Due to dependency binding issues introduced with .NET standard, the incorrect System.Net.Http package may be resolved and lead to exceptions at runtime.
This fix prevents calling this API on net462 targets which includes any .NET Framework version < .NET 4.7.2.
This introduces the net472 target so that we can resume using this API from that version, where it was included in the box.
Fixes #2212