-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return total memory when limit is max value. #2214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
force-pushed
the
cgroup-memory
branch
3 times, most recently
from
November 9, 2023 07:58
4737bdc
to
fd43ac2
Compare
stevejgordon
force-pushed
the
cgroup-memory
branch
from
November 9, 2023 15:10
89903d0
to
052fe29
Compare
Mpdreamz
reviewed
Nov 13, 2023
Mpdreamz
previously approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 left a few nitpicks.
benchmarks/Elastic.Apm.Benchmarks/FreeAndTotalMemoryProviderBenchmarks.cs
Outdated
Show resolved
Hide resolved
- Implement changes to unlimited memory metric. - Remove inactive_file.bytes per elastic/apm#339 - Refactor code - Optimise code to avoid allocations.
stevejgordon
force-pushed
the
cgroup-memory
branch
from
November 15, 2023 09:18
d17fbb1
to
25c469d
Compare
stevejgordon
force-pushed
the
cgroup-memory
branch
from
November 15, 2023 09:43
4fd8910
to
1718243
Compare
Mpdreamz
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cgroup v1 the process is unlimited when
memory.limit_in_bytes
has a value of "9223372036854771712". On cgroup v2 it is whenmemory.max
has a value of "max". In either case, we now return the total memory for this metric.Relates to elastic/apm#814
Closes #2125
Also removed inactive_file.bytes per elastic/apm#339
In the process of refactoring and updating the code in the PR, I took the opportunity to profile the code and reduce the allocation overhead of getting metric samples for two providers.
CGroup Metric Provider
LINUX:
Free and Total Memory Provider
WINDOWS:
LINUX: