Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: link to the original Pull Request #2217

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 7, 2023

What

Add the original Pull Request that contains the changes in the specs to be in the description of the Pull Request created with the updatecli automation. This will help with track what APM Agents use it.

Test

Given the updatecli and gh cli

When running

$ GIT_USER=foo \
GIT_EMAIL=1 \
GITHUB_TOKEN=*** \
updatecli apply --config .ci/updatecli.d/update-gherkin-specs.yml --push=false --debug

Then

...
✔ content: found from file "https://github.com/elastic/apm/commit/main.patch":
From 94b8365d8400b6c119ebef3845e95109c5c5462e 
...
----
https://github.com/elastic/apm/pull/830
----
...

In addition to the GitHub commit to help with tracking the consumers
@v1v v1v added the automation label Nov 7, 2023
@v1v v1v requested review from a team November 7, 2023 12:22
@v1v v1v self-assigned this Nov 7, 2023
reakaleek
reakaleek previously approved these changes Nov 7, 2023
.ci/updatecli.d/update-specs.yml Outdated Show resolved Hide resolved
@v1v
Copy link
Member Author

v1v commented Nov 8, 2023

In other words, this change will modify PRs like #2197, that won't contain the link to the commit but also the PR.

image

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love this thanks you!

@Mpdreamz Mpdreamz merged commit dbbcd45 into elastic:main Nov 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants