Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable IIS tests #2237

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Reenable IIS tests #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0474be2
Reenable IIS tests
Mpdreamz Dec 12, 2023
2217d64
Merge branch 'main' into feature/reenable-iis-tests
Mpdreamz Dec 13, 2023
6054ada
Merge branch 'main' into feature/reenable-iis-tests
Mpdreamz Feb 5, 2024
90582fb
WARN on nuget sec vuln warnings https://learn.microsoft.com/en-us/dot…
Mpdreamz Feb 5, 2024
4ce0ae9
Merge branch 'main' into feature/reenable-iis-tests
Mpdreamz Feb 5, 2024
7edc733
attempt to clean prior to building
Mpdreamz Feb 5, 2024
e487a8c
Remove PlatformTarget
Mpdreamz Feb 5, 2024
46f6b19
Another attempt to make Sample.Microsoft.Data.SqlClient build through…
Mpdreamz Feb 5, 2024
eede6be
brute force rights on temporary asp.net files
Mpdreamz Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/test-windows-iis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ jobs:
test-iis:
runs-on: windows-latest

# disable IIS on CI for now.
# Run locally and started failing randomly on github actions
# Could be because of plethora of reasons including no disk space
# Requires longer investigation
if: ${{ false }}

steps:
- uses: actions/checkout@v4
- name: Bootstrap Action Workspace
Expand All @@ -46,9 +40,19 @@ jobs:
with:
path: ~/.nuget/packages
key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.[cf]sproj*') }}

- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@v1.3.1
uses: microsoft/setup-msbuild@v2


- name: Clean the application
shell: cmd
run: msbuild /t:Clean /p:Configuration=Release

- name: Restore the application
shell: cmd
run: msbuild /t:Restore /p:Configuration=Release

- name: Build the application
shell: cmd
run: |
Expand All @@ -74,9 +78,13 @@ jobs:
shell: cmd
run: |
REM enable permissions for the Application Pool Identity group
icacls C:\Windows\Temp /grant "IIS_IUSRS:(OI)(CI)F" /T
icacls "c:\Windows\Microsoft.NET\Framework64\v4.0.30319\Temporary ASP.NET Files" /grant "IIS_IUSRS:(OI)(CI)F" /T
icacls %cd% /t /q /grant "IIS_IUSRS:(OI)(CI)(IO)(RX)"
REM enable permissions for the anonymous access group
icacls %cd% /t /q /grant "IUSR:(OI)(CI)(IO)(RX)"
icacls C:\Windows\Temp /grant "IUSR:(OI)(CI)F" /T
icacls "c:\Windows\Microsoft.NET\Framework64\v4.0.30319\Temporary ASP.NET Files" /grant "IUSR:(OI)(CI)F" /T

- name: Run tests
shell: cmd
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<LangVersion>latest</LangVersion>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>NU1701,NU1503,NU1608,CS8002,</NoWarn>
<WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
<!-- suppress NETSDK1138 warnings for EOL frameworks -->
<CheckEolTargetFramework>false</CheckEolTargetFramework>
<SolutionRoot>$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), build.bat))</SolutionRoot>
Expand Down
3 changes: 1 addition & 2 deletions sample/Sample.Microsoft.Data.SqlClient/Sample.Microsoft.Data.SqlClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net462;net6.0;net7.0</TargetFrameworks>
gregkalapos marked this conversation as resolved.
Show resolved Hide resolved
<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
<OutputType>Exe</OutputType>
<PlatformTarget>x64</PlatformTarget>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>Sample.SqlClient.DiagnosticSourceListener</RootNamespace>
Expand Down
Loading