Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging to outgoing http call propagation #2247

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jan 2, 2024

In particular adds logging when

  • outgoing http call is already otherwise instrumented
  • Outgoing call is part of an exit span and we don't create a child span for it

In particular adds logging when
- outgoing http call is already otherwise instrumented
- Outgoing call is part of an exit span and we don't create a child span for it
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 1f4d715 into main Jan 3, 2024
14 checks passed
@Mpdreamz Mpdreamz deleted the fix/propagation-logging branch January 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants