Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2266 Cleanup of packages thanks to Framework reference #2267

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jan 28, 2024

This request removes the explicit dependencies for a number of packages and that is made possible due to the framework natively providing those dependencies hence explicit is not needed.

Closes: #2266

Copy link

👋 @thompson-tomo Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 3, 2024

run elasticsearch-ci/docs

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty @thompson-tomo !

@thompson-tomo
Copy link
Contributor Author

No probs @Mpdreamz note in #2264 I have also added that the licence type is set for the packages.

@Mpdreamz Mpdreamz merged commit e2f156f into elastic:main Feb 4, 2024
13 checks passed
@thompson-tomo thompson-tomo deleted the chore/#2266_CleanupPackages branch February 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cleanup package reference in Elastic.Apm.AspNetCore for net 6 TFM
2 participants