Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: github secrets if no forked prs #2273

Merged
merged 1 commit into from
Feb 1, 2024
Merged

action: github secrets if no forked prs #2273

merged 1 commit into from
Feb 1, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 1, 2024

GH secrets cannot be accessed in forked PRs.

This should help with enabling the github secret if no forked-prs

Mpdreamz
Mpdreamz approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @v1v will follow up with a PR from a fork to disable tests that require docker on windows.

@v1v v1v marked this pull request as ready for review February 1, 2024 16:59
@v1v
Copy link
Member Author

v1v commented Feb 1, 2024

run elasticsearch-ci/docs

@v1v v1v merged commit bdc8378 into main Feb 1, 2024
16 checks passed
@Mpdreamz Mpdreamz deleted the feature/split-test-containers-access branch February 2, 2024 12:05
@Mpdreamz Mpdreamz mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
agent-dotnet
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @Mpdreamz