updatecli: rename update-compose.yaml to updatecli-compose.yaml #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
requested changes
Aug 2, 2024
| @@ -0,0 +1,3 @@ | |||
| spec: | |||
There was a problem hiding this comment.
This might cause some issues, see
apm-agent-go/update-compose.yaml
Line 22 in 7a13717
There was a problem hiding this comment.
I think we don't need to rename the values.d files but the content only to point to the updatecli-compose.yaml in the root folder
There was a problem hiding this comment.
Ah, missed that. thank you.
Good I only ran the script for this repo.
There was a problem hiding this comment.
No worries, i also missed to review this condition in the PR 👼
There was a problem hiding this comment.
I'm gonna close this and re-run the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Rename
update-compose.yamltoupdatecli-compose.yamlWhy
In https://github.com/updatecli/updatecli/releases/tag/v0.80.0 the
update-compose.yamlfile name was deprecated in favour ofupdatecli-compose.yaml.If there are any questions, please reach out to the @elastic/observablt-ci