-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate docs from AsciiDoc to Markdown #2221
base: main
Are you sure you want to change the base?
Conversation
run docs-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gone through all but there a few things broken
|
||
The precedence is as follows: | ||
|
||
* [Central configuration](#config-central_config) (supported options are marked with [ ](#dynamic-configuration)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a known issue: elastic/docs-builder#601
docs/reference/lambda-support.md
Outdated
|
||
## Step 1: Select the AWS Region and Architecture [_step_1_select_the_aws_region_and_architecture] | ||
|
||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendering of this is broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a closer look at this today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elastic/docs-builder does not support CSS and JavaScript in Markdown, and there is no plan to support it in the future. I made some updates in e795df5. Take a look at the preview and let me know what you think about this approach.
@@ -0,0 +1,5 @@ | |||
toc: | |||
- file: index.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected for now. It will be resolved when we're able to bundle pages from all repos together. elastic/docs-builder#621
- file: performance-tuning.md | ||
- file: upgrading.md | ||
children: | ||
- file: upgrading-6.x.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links to these do not work in preview, the js call gets a 403
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a known issue: elastic/docs-builder#625
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Migrate docs from AsciiDoc to Markdown. The preview can be built after #2220 is merged.