-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add benchmarks that take ndjson in `/aggregators/testdata/` and run aggregator on it. No ndjson file is added to the PR. Users should add ndjson file manually to a gitignored directory `/aggregators/testdata/`. ndjson files can be downloaded from apm-perf repo.
- Loading branch information
Showing
5 changed files
with
172 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
// or more contributor license agreements. Licensed under the Elastic License 2.0; | ||
// you may not use this file except in compliance with the Elastic License 2.0. | ||
|
||
package aggregators | ||
|
||
import ( | ||
"bufio" | ||
"context" | ||
"fmt" | ||
"io" | ||
"io/fs" | ||
"math" | ||
"os" | ||
"testing" | ||
|
||
"go.uber.org/zap" | ||
"golang.org/x/sync/semaphore" | ||
"google.golang.org/protobuf/types/known/timestamppb" | ||
|
||
"github.com/elastic/apm-data/input/elasticapm" | ||
"github.com/elastic/apm-data/model/modelpb" | ||
"github.com/elastic/apm-data/model/modelprocessor" | ||
) | ||
|
||
func ndjsonToBatch(reader io.Reader) (*modelpb.Batch, error) { | ||
logger, err := zap.NewDevelopment() | ||
if err != nil { | ||
return nil, err | ||
} | ||
elasticapmProcessor := elasticapm.NewProcessor(elasticapm.Config{ | ||
Logger: logger, | ||
MaxEventSize: 1024 * 1024, // 1MiB | ||
Semaphore: semaphore.NewWeighted(1), | ||
}) | ||
baseEvent := modelpb.APMEvent{ | ||
Event: &modelpb.Event{ | ||
Received: timestamppb.Now(), | ||
}, | ||
} | ||
var batch modelpb.Batch | ||
processor := modelprocessor.Chained{ | ||
modelprocessor.SetHostHostname{}, | ||
modelprocessor.SetServiceNodeName{}, | ||
modelprocessor.SetGroupingKey{}, | ||
modelprocessor.SetErrorMessage{}, | ||
modelpb.ProcessBatchFunc(func(ctx context.Context, b *modelpb.Batch) error { | ||
batch = make(modelpb.Batch, len(*b)) | ||
copy(batch, *b) | ||
return nil | ||
}), | ||
} | ||
|
||
var elasticapmResult elasticapm.Result | ||
if err := elasticapmProcessor.HandleStream( | ||
context.TODO(), | ||
false, // async | ||
&baseEvent, | ||
reader, | ||
math.MaxInt32, // batch size | ||
processor, | ||
&elasticapmResult, | ||
); err != nil { | ||
return nil, fmt.Errorf("stream error: %w", err) | ||
} | ||
return &batch, nil | ||
} | ||
|
||
// forEachNDJSON loops over ndjson files in testdata. | ||
// The directory is empty by default but the ndjson files can be downloaded from the apm-perf repo. | ||
func forEachNDJSON(b *testing.B, f func(*testing.B, *modelpb.Batch)) { | ||
dirFS := os.DirFS("testdata") | ||
matches, err := fs.Glob(dirFS, "*.ndjson") | ||
if err != nil { | ||
b.Fatal(err) | ||
} | ||
for _, filename := range matches { | ||
b.Run(filename, func(b *testing.B) { | ||
file, err := dirFS.Open(filename) | ||
if err != nil { | ||
b.Fatal(err) | ||
} | ||
defer file.Close() | ||
|
||
batch, err := ndjsonToBatch(bufio.NewReader(file)) | ||
if err != nil { | ||
b.Fatal(err) | ||
} | ||
f(b, batch) | ||
}) | ||
} | ||
} | ||
|
||
func BenchmarkNDJSONSerial(b *testing.B) { | ||
forEachNDJSON(b, func(b *testing.B, batch *modelpb.Batch) { | ||
agg := newTestAggregator(b) | ||
b.Cleanup(func() { | ||
agg.Close(context.TODO()) | ||
}) | ||
cmID := EncodeToCombinedMetricsKeyID(b, "ab01") | ||
b.ResetTimer() | ||
|
||
for i := 0; i < b.N; i++ { | ||
if err := agg.AggregateBatch(context.Background(), cmID, batch); err != nil { | ||
b.Fatal(err) | ||
} | ||
} | ||
}) | ||
} | ||
|
||
func BenchmarkNDJSONParallel(b *testing.B) { | ||
forEachNDJSON(b, func(b *testing.B, batch *modelpb.Batch) { | ||
agg := newTestAggregator(b) | ||
b.Cleanup(func() { | ||
agg.Close(context.TODO()) | ||
}) | ||
cmID := EncodeToCombinedMetricsKeyID(b, "ab01") | ||
b.ResetTimer() | ||
|
||
b.RunParallel(func(pb *testing.PB) { | ||
for pb.Next() { | ||
if err := agg.AggregateBatch(context.Background(), cmID, batch); err != nil { | ||
b.Fatal(err) | ||
} | ||
} | ||
}) | ||
}) | ||
} |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters