-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global labels value regression tests #191
Merged
Merged
Commits on Aug 14, 2024
-
A basic test to verify the converted bug in handling tags.
Configuration menu - View commit details
-
Copy full SHA for 49d0906 - Browse repository at this point
Copy the full SHA 49d0906View commit details -
refactor TestAggregateAndHarvest
Refactor to allow running the same test logic with different inputs and expected results.
Configuration menu - View commit details
-
Copy full SHA for 6c0a6ab - Browse repository at this point
Copy the full SHA 6c0a6abView commit details -
add global labels values test case
Add an e2e test for global labels values with multiple events. A batch of 2 events in input with different labels Values but same key should produce in output events with all different Values added to the same key.
Configuration menu - View commit details
-
Copy full SHA for 57265b3 - Browse repository at this point
Copy the full SHA 57265b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f629f5 - Browse repository at this point
Copy the full SHA 3f629f5View commit details -
We only retain the latest tags in a batch of events.
Configuration menu - View commit details
-
Copy full SHA for aa210a6 - Browse repository at this point
Copy the full SHA aa210a6View commit details -
TestAggregateAndHarvest sort logic only used Metricset.Name. The latest test added to it s flappy with such a logic, as we are evaluating the same Metricset.Names in 2 different events with global labels with equal key and different values. Enhance the sorting logic to account for equal Metricset.Name and leverage labels (keys, Value and Values) in the lessFn.
Configuration menu - View commit details
-
Copy full SHA for 5e01ab2 - Browse repository at this point
Copy the full SHA 5e01ab2View commit details -
fix TestAggregateAndHarvest expectations
When 2 events in a batch have the same service name but different tags we output 2 different sets of metrics, one for each tag set. This was not considered in the previous expected values.
Configuration menu - View commit details
-
Copy full SHA for 93dbb9d - Browse repository at this point
Copy the full SHA 93dbb9dView commit details -
Revert "add converted failing test"
This reverts commit 49d0906. The same test is covered by TestMarshalEventGlobalLabelsRace, which also test for a possible race condition.
Configuration menu - View commit details
-
Copy full SHA for e2fcbec - Browse repository at this point
Copy the full SHA e2fcbecView commit details
Commits on Aug 19, 2024
-
There was a typo, this loop should have iterated over b.Labels but was iterating over a.Labels
Configuration menu - View commit details
-
Copy full SHA for 86f24d9 - Browse repository at this point
Copy the full SHA 86f24d9View commit details -
The previous implementation could panic if len(b) > len(a). Add a guard clause that limit iterating over label based on len(b). If len(a.Labels) > len(b.Labels), everything else equal we conclude that a > b.
Configuration menu - View commit details
-
Copy full SHA for 3b3a56b - Browse repository at this point
Copy the full SHA 3b3a56bView commit details
Commits on Aug 20, 2024
-
Leverage a string comparison as a sort function, as used in https://github.com/elastic/apm-data/blob/81d77648a3b17d4e52859110e233e40683fcdfe3/input/otlp/metrics_test.go#L1146-L1148 Adds an additional tag to the test case to ensure expected results.
Configuration menu - View commit details
-
Copy full SHA for 396c6e5 - Browse repository at this point
Copy the full SHA 396c6e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9953142 - Browse repository at this point
Copy the full SHA 9953142View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.