Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests due to changes in the geoip database #13073

Closed
lahsivjar opened this issue May 2, 2024 · 0 comments · Fixed by #13083
Closed

Flaky tests due to changes in the geoip database #13073

lahsivjar opened this issue May 2, 2024 · 0 comments · Fixed by #13083
Labels

Comments

@lahsivjar
Copy link
Contributor

lahsivjar commented May 2, 2024

APM Server version (apm-server version): all

Description of the problem including expected versus actual behavior: There are frequent test failures due to changes to the geoip database. This leads to unnecessary time in fixing these and then eventually reverting the fixes.

Get to the bottom of why these changes happen and how we can minimize impact for us. If these changes are to be expected then update the test to only assert that geoip db is indeed working by checking for the existence of a single client.geo.* field.

Provide logs (if relevant):

https://github.com/elastic/apm-server/actions/runs/8921322845/job/24501200877?pr=13066

=== FAIL: systemtest TestOTLPGRPCLogsClientIP (1.57s)
    otlp_test.go:521:   []any{
          	map[string]any{
          		"@timestamp":                  []any{string("1970-01-01T00:00:01.000Z")},
          		"agent.name":                  []any{string("android/java")},
          		"agent.version":               []any{string("unknown")},
        - 		"client.geo.city_name":        []any{string("dynamic")},
          		"client.geo.continent_name":   []any{string("Europe")},
          		"client.geo.country_iso_code": []any{string("DE")},
          		"client.geo.country_name":     []any{string("Germany")},
          		"client.geo.location":         []any{string("dynamic")},
        - 		"client.geo.region_iso_code":  []any{string("dynamic")},
        - 		"client.geo.region_name":      []any{string("dynamic")},
          		"client.ip":                   []any{string("178.162.206.244")},
          		"data_stream.dataset":         []any{string("apm.app.unknown")},
          		... // 16 identical entries
          	},
          }
        
        Test failed. Run `make check-approvals` to verify the diff.
        
    server.go:133: log file: /home/runner/work/apm-server/apm-server/systemtest/logs/TestOTLPGRPCLogsClientIP/apm-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant