Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use maxmind db test ip to reduce flaky test #13083

Merged
merged 1 commit into from
May 6, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented May 6, 2024

Motivation/summary

Update test to use IP from https://github.com/maxmind/MaxMind-DB/blame/main/source-data/GeoIP2-City-Test.json to reduce flaky test and stable output

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #13073

@kruskall kruskall requested a review from a team as a code owner May 6, 2024 16:30
@kruskall kruskall enabled auto-merge (squash) May 6, 2024 16:31
@kruskall kruskall added backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify labels May 6, 2024
@kruskall kruskall merged commit 17ace23 into elastic:main May 6, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request May 6, 2024
mergify bot pushed a commit that referenced this pull request May 6, 2024
mergify bot added a commit that referenced this pull request May 7, 2024
(cherry picked from commit 17ace23)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
mergify bot added a commit that referenced this pull request May 7, 2024
(cherry picked from commit 17ace23)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
@kruskall kruskall deleted the feat/update-geoip branch May 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests due to changes in the geoip database
2 participants