test: use tls 1.2 on TLSClientAuth test #11510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is failing on Go 1.21+ because the alert/error message was fixed is now returning 'certificate required' instead of 'bad certificate'. See https://go.dev/doc/go1.21#crypto/tls
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
|
|
I guess so, I've rerun the tests |
dmathieu
approved these changes
Aug 29, 2023
simitt
approved these changes
Aug 29, 2023
bmorelli25
pushed a commit
to bmorelli25/apm-server
that referenced
this pull request
Sep 5, 2023
This test is failing on Go 1.21+ because the alert/error message was fixed is now returning 'certificate required' instead of 'bad certificate'. See https://go.dev/doc/go1.21#crypto/tls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This test is failing on Go 1.21+ because the alert/error message was fixed is now returning 'certificate required' instead of 'bad certificate'.
See https://go.dev/doc/go1.21#crypto/tls
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackagehave been made)- [ ] Documentation has been updatedFor functional changes, consider:
How to test these changes
GOTESTFLAGS="-run=TestTLSClientAuth" make system-testRelated issues
Closes #11500