Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes // from Node.js link (#11560) #11561

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Removes // from Node.js link (#11560) #11561

merged 1 commit into from
Aug 31, 2023

Conversation

kruskall
Copy link
Member

Changes {apm-node-ref-v}//configuration.html#capture-body to {apm-node-ref-v}/configuration.html#capture-body

Motivation/summary

Manually "backporting" #11560 to main

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@KOTungseth @kruskall
[8.9] docs: Removes // from Node.js link (elastic#11560)
9e8d236 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`
@kruskall kruskall added the backport-8.10 Automated backport with mergify label Aug 31, 2023
@kruskall kruskall requested a review from a team as a code owner August 31, 2023 20:23
@kruskall kruskall enabled auto-merge (squash) August 31, 2023 20:23
@kruskall kruskall merged commit ce978d2 into elastic:main Aug 31, 2023
5 checks passed
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@kruskall @mergify
Removes // from Node.js link (#11561)
af16562 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
(cherry picked from commit ce978d2)
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
mergify bot added a commit that referenced this pull request Aug 31, 2023
@mergify @kruskall
Removes // from Node.js link (#11561) (#11562)
37c5b7d 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
(cherry picked from commit ce978d2)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
@kruskall kruskall deleted the fix/docs-nodejs-link branch August 31, 2023 21:25
bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Sep 5, 2023
@kruskall @KOTungseth @bmorelli25
Removes // from Node.js link (elastic#11561)
5e8e100 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-8.10 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruskall @KOTungseth