Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing changelog line to 8.10.asciidoc #11659

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Add missing changelog line to 8.10.asciidoc #11659

merged 1 commit into from
Sep 18, 2023

Conversation

carsonip
Copy link
Member

Motivation/summary

Fix missing changelog line in #11656

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip added the backport-8.10 Automated backport with mergify label Sep 18, 2023
@carsonip carsonip requested a review from a team as a code owner September 18, 2023 15:17
marclop
marclop approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@carsonip
Copy link
Member Author

cc @bmorelli25

@carsonip carsonip enabled auto-merge (squash) September 18, 2023 15:22
bmorelli25
bmorelli25 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thank you!

@carsonip carsonip merged commit df22228 into main Sep 18, 2023
9 checks passed
@carsonip carsonip deleted the carsonip-patch-1 branch September 18, 2023 15:30
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
@carsonip @mergify
Add missing changelog line to 8.10.asciidoc (#11659)
5de9b1f 
Fix missing changelog line in #11656.

(cherry picked from commit df22228)
@mergify mergify bot mentioned this pull request Sep 18, 2023
Merged
mergify bot added a commit that referenced this pull request Sep 18, 2023
@mergify @carsonip
Add missing changelog line to 8.10.asciidoc (#11659) (#11661)
419d2b0 
Fix missing changelog line in #11656.

(cherry picked from commit df22228)

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@marclop marclop marclop approved these changes

Assignees
No one assigned
Labels
backport-8.10 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonip @bmorelli25 @marclop