Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-docappender to v2 #13155

Merged
merged 5 commits into from
May 16, 2024
Merged

Upgrade go-docappender to v2 #13155

merged 5 commits into from
May 16, 2024

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented May 13, 2024

Motivation/summary

go-docappender/v2 fixes a crucial bug with data race: elastic/go-docappender#162

It also has some other fixes though they don't apply to apm-server since apm-server doesn't have document retries enabled:

In addition, it also exposes a new metric for elasticsearch flushed bytes: elastic/go-docappender#161

Checklist

How to test these changes

Related issues

N/A

@lahsivjar lahsivjar requested a review from a team as a code owner May 13, 2024 19:04
Copy link
Contributor

mergify bot commented May 13, 2024

This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 13, 2024
[float]
==== Bug fixes

- Avoid data race due to reuse of `bytes.Buffer` in ES bulk requests {pull}13155[13155]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For reviewers] I have added changelog entries to APM-Server for go-docappender fixes so that they can be tested and documented. Let me know if this doesn't sound like a good idea.

kruskall
kruskall previously approved these changes May 13, 2024
@lahsivjar lahsivjar enabled auto-merge (squash) May 16, 2024 12:08
carsonip
carsonip previously approved these changes May 16, 2024
@lahsivjar lahsivjar dismissed stale reviews from carsonip and kruskall via d8b0da2 May 16, 2024 12:37
@lahsivjar lahsivjar merged commit 981fbd4 into elastic:main May 16, 2024
13 checks passed
@lahsivjar lahsivjar deleted the up-godoc branch May 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants