Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(buildkite): use shared secrets #13526

Merged
merged 1 commit into from
Jul 1, 2024
Merged

ci(buildkite): use shared secrets #13526

merged 1 commit into from
Jul 1, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 1, 2024

Motivation/summary

Use shared secrets in Buildkite. There are some other projects using it.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify labels Jul 1, 2024
@v1v v1v self-assigned this Jul 1, 2024
@v1v v1v marked this pull request as ready for review July 1, 2024 09:19
@v1v v1v requested a review from a team as a code owner July 1, 2024 09:19
@v1v v1v requested a review from a team July 1, 2024 09:19
@v1v v1v merged commit 0e77c56 into main Jul 1, 2024
11 checks passed
@v1v v1v deleted the feature/use-shared-secret branch July 1, 2024 10:19
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
@v1v @mergify
ci(buildkite): use shared secrets (#13526)
35fb6d0 
(cherry picked from commit 0e77c56)
@mergify mergify bot mentioned this pull request Jul 1, 2024
Merged
2 tasks
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
@v1v @mergify
ci(buildkite): use shared secrets (#13526)
6219a74 
(cherry picked from commit 0e77c56)
@mergify mergify bot mentioned this pull request Jul 1, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Jul 1, 2024
@mergify @v1v
ci(buildkite): use shared secrets (#13526) (#13527)
4458c43 
(cherry picked from commit 0e77c56)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
mergify bot added a commit that referenced this pull request Jul 1, 2024
@mergify @v1v
ci(buildkite): use shared secrets (#13526) (#13528)
fd00bb2 
(cherry picked from commit 0e77c56)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reakaleek reakaleek reakaleek approved these changes

@kruskall kruskall kruskall approved these changes

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @reakaleek @kruskall