[8.15] fix: Update FlushBytes parsing/defaults (backport #13576)
#13595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
marclop
approved these changes
Jul 5, 2024
marclop
reviewed
Jul 5, 2024
| @@ -9,6 +9,7 @@ https://github.com/elastic/apm-server/compare/8.14\...main[View commits] | |||
| - Avoid data race due to reuse of `bytes.Buffer` in ES bulk requests {pull}13155[13155] | |||
| - APM Server now relies on the Elasticsearch apm-data plugin's index templates, which reverts some unsafe uses of `flattened` field types {pull}12066[12066] | |||
| - Add `error.id` to jaeger errors {pull}13196[13196] | |||
| - Fix a performance regression for apm servers which don't specify `output.elasticsearch.flush_bytes` {pull}13576[13576] | |||
There was a problem hiding this comment.
We'll see whether this makes it to 8.14.3.
kruskall
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Updates the
FlushBytessetting to default to 1 mib and only override to 24kb if the user has explicitly set it to 24kb.Checklist
- [ ] Documentation has been updatedHow to test these changes
Related issues
Fixes #13024
This is an automatic backport of pull request #13576 done by [Mergify](https://mergify.com).