-
Notifications
You must be signed in to change notification settings - Fork 537
test: replace apmsoak with the one in apm-perf #18652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update docs to reference apmsoak binary in apm-perf remove custom apmsoak package in systemtest module update soaktest_workers terraform module to use new apmsoak update apmsoak folder readme and remove section about deleted apmsoak terraform module
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the diff looks reasonable. Have you tested it by running the new tf?
Tested and works fine! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks for testing
Motivation/summary
update docs to reference apmsoak binary in apm-perf
remove custom apmsoak package in systemtest module
update soaktest_workers terraform module to use new apmsoak
update apmsoak folder readme and remove section about deleted apmsoak terraform module
Checklist
For functional changes, consider:
How to test these changes
Related issues
Closes #11698