Skip to content

Conversation

kruskall
Copy link
Member

Motivation/summary

update docs to reference apmsoak binary in apm-perf

remove custom apmsoak package in systemtest module

update soaktest_workers terraform module to use new apmsoak

update apmsoak folder readme and remove section about deleted apmsoak terraform module

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #11698

update docs to reference apmsoak binary in apm-perf

remove custom apmsoak package in systemtest module

update soaktest_workers terraform module to use new apmsoak

update apmsoak folder readme and remove section about
deleted apmsoak terraform module
@kruskall kruskall requested a review from a team as a code owner September 17, 2025 15:21
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Sep 17, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the diff looks reasonable. Have you tested it by running the new tf?

@kruskall
Copy link
Member Author

Tested and works fine! 👍

@kruskall kruskall requested review from a team and carsonip October 10, 2025 15:40
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for testing

@kruskall kruskall added this pull request to the merge queue Oct 10, 2025
Merged via the queue into elastic:main with commit 49355ee Oct 10, 2025
23 of 24 checks passed
@kruskall kruskall deleted the test/replace-apmsoak-apmperf branch October 10, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace apmsoak with the one in apm-perf

2 participants