-
Notifications
You must be signed in to change notification settings - Fork 536
test: close apmserver before waiting for geoip download #18897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close apmserver while waiting for geoip db to be downloaded resolve flaky aggregation systemtest caused by leaking server pushing aggregation metrics
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
lahsivjar
approved these changes
Oct 7, 2025
@Mergifyio backport 9.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
* test: close apmserver before waiting for geoip download close apmserver while waiting for geoip db to be downloaded resolve flaky aggregation systemtest caused by leaking server pushing aggregation metrics * Update main_test.go (cherry picked from commit 931f8b3)
2 tasks
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2025
) * test: close apmserver before waiting for geoip download close apmserver while waiting for geoip db to be downloaded resolve flaky aggregation systemtest caused by leaking server pushing aggregation metrics * Update main_test.go (cherry picked from commit 931f8b3) Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
close apmserver while waiting for geoip db to be downloaded
resolve flaky aggregation systemtest caused by leaking server pushing aggregation metrics
Checklist
For functional changes, consider:
How to test these changes
cd systemtest && go test -race -count=100 -failfast -v -run=TestServiceSummaryMetricsAggregation -timeout=60m ./...
Related issues
Related to #18558