Skip to content

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Oct 2, 2025

Motivation/summary

close apmserver while waiting for geoip db to be downloaded

resolve flaky aggregation systemtest caused by leaking server pushing aggregation metrics

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • cd systemtest && go test -race -count=100 -failfast -v -run=TestServiceSummaryMetricsAggregation -timeout=60m ./...

Related issues

Related to #18558

close apmserver while waiting for geoip db to be downloaded

resolve flaky aggregation systemtest caused by leaking server
pushing aggregation metrics
@kruskall kruskall requested a review from a team as a code owner October 2, 2025 10:14
Copy link
Contributor

github-actions bot commented Oct 2, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Oct 2, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@kruskall kruskall added this pull request to the merge queue Oct 7, 2025
Merged via the queue into elastic:main with commit 931f8b3 Oct 7, 2025
19 checks passed
@kruskall kruskall deleted the systemtest/wait-geoip-leak branch October 7, 2025 14:24
@kruskall
Copy link
Member Author

kruskall commented Oct 9, 2025

@Mergifyio backport 9.2

Copy link
Contributor

mergify bot commented Oct 9, 2025

backport 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 9, 2025
* test: close apmserver before waiting for geoip download

close apmserver while waiting for geoip db to be downloaded

resolve flaky aggregation systemtest caused by leaking server
pushing aggregation metrics

* Update main_test.go

(cherry picked from commit 931f8b3)
mergify bot added a commit that referenced this pull request Oct 9, 2025
)

* test: close apmserver before waiting for geoip download

close apmserver while waiting for geoip db to be downloaded

resolve flaky aggregation systemtest caused by leaking server
pushing aggregation metrics

* Update main_test.go

(cherry picked from commit 931f8b3)

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants