Add ApproveFields for approving flattened fields #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApproveFields approves flattened fields, including runtime fields, rather than document _source. We also add cmd/flatten-approvals for converting existing _source-based approvals to flattened fields. They may not be perfectly aligned (e.g. we can't materialise runtime fields from source in this way), but this gives us a way to perform a mechanical translation before switching to ApproveFields, minimising the non-mechanical diff.
lahsivjar
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApproveFields approves flattened fields, including runtime fields, rather than document _source.
We also add cmd/flatten-approvals for converting existing _source-based approvals to flattened fields. The results may not be perfectly aligned with the results of using ApproveFields (e.g. we can't materialise runtime fields from source in this way), but this gives us a way to perform a mechanical translation before switching to ApproveFields, minimising the non-mechanical diff.
Required for elastic/apm-server#12066, which moves some processing out of ingest pipelines and into indexed runtime fields.