-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filebeat/input/syslog: Improve Cisco log parsing #37748
filebeat/input/syslog: Improve Cisco log parsing #37748
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
85aac18
to
3b83e7e
Compare
💔 Build Failed
Expand to view the summary
Build stats
Pipeline error
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
💔 Build Failed
Expand to view the summary
Build stats
Pipeline error
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
3b83e7e
to
462be06
Compare
- Improved cisco log parsing to handle both sequence number and hostname - Added tests
462be06
to
aed82f3
Compare
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
After some internal discussions, I've decided to abandon this change. It was discovered that there are several more formats that aren't covered by the change, and we would need to support all of these cases. Supporting these formats would require more extensive changes to the parser. Considering that the input is going to be deprecated soon, there are better alternatives to explore. |
Proposed commit message
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Unit tests:
filebeat/input/syslog
System test:
Related issues