Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat] Delete proxy queue #38570

Merged
merged 9 commits into from
Apr 5, 2024
Merged

[libbeat] Delete proxy queue #38570

merged 9 commits into from
Apr 5, 2024

Conversation

faec
Copy link
Contributor

@faec faec commented Mar 22, 2024

Delete the proxy queue, a prototype written to reduce memory use in the old shipper project. Recent improvements to the memory queue (#37795, #38166) added support for the same early-free mechanisms as the proxy queue, so it is now redundant.

The proxy queue was never used or exposed in a public release, so there are no compatibility concerns.

(This is pre-cleanup for adding early-encoding support, to avoid implementing new functionality in a queue that is no longer used.)

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added cleanup Team:Elastic-Agent Label for the Agent team labels Mar 22, 2024
@faec faec self-assigned this Mar 22, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 22, 2024
Copy link
Contributor

mergify bot commented Mar 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@faec faec marked this pull request as ready for review March 22, 2024 22:32
@faec faec requested a review from a team as a code owner March 22, 2024 22:32
@faec faec requested review from ycombinator and belimawr March 22, 2024 22:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-05T13:24:54.898+0000

  • Duration: 134 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 29254
Skipped 2061
Total 31315

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@faec faec merged commit d6d92ef into elastic:main Apr 5, 2024
183 of 185 checks passed
@faec faec deleted the delete-proxy-queue branch April 5, 2024 15:42
zeynepyz pushed a commit to zeynepyz/beats that referenced this pull request Apr 7, 2024
Delete the proxy queue, a prototype written to reduce memory use in the old shipper project. Recent improvements to the memory queue (elastic#37795, elastic#38166) added support for the same early-free mechanisms as the proxy queue, so it is now redundant.

The proxy queue was never used or exposed in a public release, so there are no compatibility concerns.

(This is pre-cleanup for adding early-encoding support, to avoid implementing new functionality in a queue that is no longer used.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants